-
Notifications
You must be signed in to change notification settings - Fork 724
Update LLVM to 21.1.2. #4654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update LLVM to 21.1.2. #4654
Conversation
450363d
to
c9e13c8
Compare
build-scripts/build_llvm.py
Outdated
"repo": "https://github.com/espressif/llvm-project.git", | ||
"repo_ssh": "[email protected]:espressif/llvm-project.git", | ||
"branch": "xtensa_release_18.1.2", | ||
"branch": "xtensa_release_21.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no such a branch availabile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I should have checked that. Looks like the new API for LLVMContext construction will have to get wrapped in an #ifdef LLVM version check, since xtensa's latest release is only LLVM 19.
c11c325
to
0a7e444
Compare
Wraps the LLVMContext construction in LLVM 21 version check; LLVM 21 makes a breaking change in LLVMContext construction, but WAMR still needs to support older LLVM versions, e.g. for xtensa/esp32 support which is only available in at most LLVM 19.
Is this good to merge? The test failures look like timeouts; one error is "fatal error: error writing to /tmp/cckAF38s.s: No space left on device" which doesn't seem relevant. Thanks! |
isn't it possible llvm 21 build actually somehow requires more space and caused ENOSPC on the ci? |
LLVM 21 update uses more disk space and makes the standard runner fail with "No space left on device". Using the [free disk space action](https://github.com/marketplace/actions/free-disk-space-ubuntu) to delete the unused Android, Haskell, and .NET runtimes frees up space on the runner.
I found a script to free up disk space on the GitHub Ubuntu runner. Is that OK to use? Seems to fix the out of space error. If you'd prefer I didn't use the action from the marketplace, I can hoist that bit out into a script in the WAMR repo and use that instead. |
This required minor changes to LLVMContext construction and PGOOptions.